From 10f6915348c5773eff87b3c9b62c25e8f81472d5 Mon Sep 17 00:00:00 2001 From: Martin Boonk Date: Sat, 6 Apr 2024 22:10:11 +0200 Subject: [PATCH] messagesoverlay - Only check version once --- apps/messagesoverlay/lib.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/messagesoverlay/lib.js b/apps/messagesoverlay/lib.js index 166ec4853..bc86ee77d 100644 --- a/apps/messagesoverlay/lib.js +++ b/apps/messagesoverlay/lib.js @@ -18,6 +18,8 @@ const isNewer = function(espruinoVersion, baseVersion){ s.patch > b.patch; }; +let needsWorkaround; + let settings = Object.assign( require('Storage').readJSON("messagesoverlay.default.json", true) || {}, require('Storage').readJSON("messagesoverlay.json", true) || {} @@ -315,10 +317,10 @@ const drawMessage = function(ovr, msg) { const getStringHeight = function(str){ "jit"; const metrics = ovr.stringMetrics(str); - if (isNewer("2v21.13", process.version)){ - if (metrics.maxImageHeight > 16) - metrics.maxImageHeight = metrics.height; - } + if (needsWorkaround === undefined) + needsWorkaround = isNewer("2v21.13", process.version); + if (needsWorkaround && metrics.maxImageHeight > 16) + metrics.maxImageHeight = metrics.height; return Math.max(metrics.height, metrics.maxImageHeight); };