From 784c7b203a759ee9819c87d171d06e719df31423 Mon Sep 17 00:00:00 2001 From: Rob Pilling Date: Wed, 12 Jul 2023 21:46:01 +0100 Subject: [PATCH 1/4] rep: fix interface.html typo --- apps/rep/interface.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/rep/interface.html b/apps/rep/interface.html index fa137bdb2..99ec1c890 100644 --- a/apps/rep/interface.html +++ b/apps/rep/interface.html @@ -59,8 +59,8 @@ function renderRep(rep) { } buttonDelete.appendChild(iconDelete); buttonDelete.onclick = (e => { - reps = reps.filter(a => a !== alarm); - document.getElementById("events").removeChild(tr); + reps = reps.filter(a => a !== rep); + document.getElementById("repsTable").removeChild(tr); }); } tdInfo.appendChild(buttonDelete); From 94ebd6bf4902f3655efbdeb91c695ea698634ae0 Mon Sep 17 00:00:00 2001 From: Rob Pilling Date: Wed, 12 Jul 2023 22:05:25 +0100 Subject: [PATCH 2/4] rep: setUI() on init, in case recorder cleared handlers --- apps/rep/app.js | 3 ++- apps/rep/app.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/rep/app.js b/apps/rep/app.js index 8172bc362..692164cc3 100644 --- a/apps/rep/app.js +++ b/apps/rep/app.js @@ -184,7 +184,7 @@ var _a, _b, _c; State.prototype.currentRepIndex = function () { var elapsed = this.getElapsedTotal(); var ent; - for (var i = 0; (ent = reps_1[i]); i++) + for (var i = 0; ent = reps_1[i]; i++) if (elapsed < ent.accDur) return i; return null; @@ -252,6 +252,7 @@ var _a, _b, _c; }; var init = function () { g.clear(); + layout_1.setUI(); drawRep_1(); Bangle.drawWidgets(); }; diff --git a/apps/rep/app.ts b/apps/rep/app.ts index 181ccd921..d34e2bca1 100644 --- a/apps/rep/app.ts +++ b/apps/rep/app.ts @@ -316,6 +316,7 @@ const buzzNewRep = () => { const init = () => { g.clear(); + layout.setUI(); drawRep(); Bangle.drawWidgets(); From e46e2bd5a18f6ca972cecc10c7ffa5a7489ceec3 Mon Sep 17 00:00:00 2001 From: Rob Pilling Date: Wed, 12 Jul 2023 22:08:55 +0100 Subject: [PATCH 3/4] rep: changelog --- apps/rep/ChangeLog | 2 ++ apps/rep/metadata.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 apps/rep/ChangeLog diff --git a/apps/rep/ChangeLog b/apps/rep/ChangeLog new file mode 100644 index 000000000..142fd767e --- /dev/null +++ b/apps/rep/ChangeLog @@ -0,0 +1,2 @@ +0.01: New app! +0.02: Fixed interaction with recorder UI listeners diff --git a/apps/rep/metadata.json b/apps/rep/metadata.json index 4b34175c8..f3c00da10 100644 --- a/apps/rep/metadata.json +++ b/apps/rep/metadata.json @@ -1,7 +1,7 @@ { "id": "rep", "name": "Rep", - "version":"0.01", + "version":"0.02", "description": "Time running reps, using a rep schedule/program uploaded via the app loader", "icon": "app.png", "tags": "run,running,fitness,outdoors", From 7f0f8cc51a3cafb4d3b179593bc9dc304cd156c8 Mon Sep 17 00:00:00 2001 From: Rob Pilling Date: Thu, 13 Jul 2023 18:15:08 +0100 Subject: [PATCH 4/4] rep: clarify assignment-and-test --- apps/rep/app.js | 2 +- apps/rep/app.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/rep/app.js b/apps/rep/app.js index 692164cc3..a30a96c09 100644 --- a/apps/rep/app.js +++ b/apps/rep/app.js @@ -184,7 +184,7 @@ var _a, _b, _c; State.prototype.currentRepIndex = function () { var elapsed = this.getElapsedTotal(); var ent; - for (var i = 0; ent = reps_1[i]; i++) + for (var i = 0; (ent = reps_1[i]); i++) if (elapsed < ent.accDur) return i; return null; diff --git a/apps/rep/app.ts b/apps/rep/app.ts index d34e2bca1..d1dd67179 100644 --- a/apps/rep/app.ts +++ b/apps/rep/app.ts @@ -233,7 +233,7 @@ class State { currentRepIndex() { const elapsed = this.getElapsedTotal(); let ent; - for(let i = 0; ent = reps[i]; i++) + for(let i = 0; (ent = reps[i]); i++) if(elapsed < ent.accDur) return i; return null;