From b99371e2782e71794cdefb28fe134c19f37a5184 Mon Sep 17 00:00:00 2001 From: thyttan <97237430+thyttan@users.noreply.github.com> Date: Tue, 5 Jul 2022 17:40:57 +0200 Subject: [PATCH 1/5] Music Messages -> Messages Music --- apps/messagesmusic/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/messagesmusic/README.md b/apps/messagesmusic/README.md index 7aa9209df..8f9c65fa4 100644 --- a/apps/messagesmusic/README.md +++ b/apps/messagesmusic/README.md @@ -8,7 +8,7 @@ It is suggested to use Messages Music along side the app Quick Launch. Messages Music v0.01 has been verified to work with Messages v0.31 on Bangle.js 2 fw2v13. -Music Messages should work with forks of the original Messages app. At least as long as functions pushMessage() in the library and showMusicMessage() in app.js hasn't been changed too much. +Messages Music should work with forks of the original Messages app. At least as long as functions pushMessage() in the library and showMusicMessage() in app.js hasn't been changed too much. Messages app is created by Gordon Williams with contributions from [Jeroen Peters](https://github.com/jeroenpeters1986). From a7f4b8392762e3b472a4f3591e855e8ef1e09f14 Mon Sep 17 00:00:00 2001 From: thyttan <97237430+thyttan@users.noreply.github.com> Date: Tue, 5 Jul 2022 18:38:41 +0200 Subject: [PATCH 2/5] Remove unnecessary line of code This change doesn't change functionality of the app. But it does make it compatible with @rigrig's version of the messages app. I think it's something to do with asynchronous code - but I'm really not qualified to say. --- apps/messagesmusic/app.js | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/messagesmusic/app.js b/apps/messagesmusic/app.js index a6f7e075e..27f3f6e4d 100644 --- a/apps/messagesmusic/app.js +++ b/apps/messagesmusic/app.js @@ -1,7 +1,6 @@ let showMusic = () => { Bangle.CLOCK = 1; // To pass condition in messages library require('messages').pushMessage({"t":"add","artist":" ","album":" ","track":" ","dur":0,"c":-1,"n":-1,"id":"music","title":"Music","state":"play","new":true}); - Bangle.CLOCK = undefined; }; var settings = require('Storage').readJSON('messages.settings.json', true) || {}; //read settings if they exist else set to empty dict From 13a79980989ddc718b9a096d48f4f7284bff7e77 Mon Sep 17 00:00:00 2001 From: thyttan <97237430+thyttan@users.noreply.github.com> Date: Tue, 5 Jul 2022 18:43:06 +0200 Subject: [PATCH 3/5] Update ChangeLog --- apps/messagesmusic/ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/messagesmusic/ChangeLog b/apps/messagesmusic/ChangeLog index 5560f00bc..9f4cafb0e 100644 --- a/apps/messagesmusic/ChangeLog +++ b/apps/messagesmusic/ChangeLog @@ -1 +1,2 @@ 0.01: New App! +0.02: Remove one line of code that didn't do anything other than in some instances hinder the function of the app. From 39a792d9ef70c3db83272b681861f6904c51c527 Mon Sep 17 00:00:00 2001 From: thyttan <97237430+thyttan@users.noreply.github.com> Date: Tue, 5 Jul 2022 18:43:33 +0200 Subject: [PATCH 4/5] Update metadata.json --- apps/messagesmusic/metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/messagesmusic/metadata.json b/apps/messagesmusic/metadata.json index edc6835ed..c29ffbc34 100644 --- a/apps/messagesmusic/metadata.json +++ b/apps/messagesmusic/metadata.json @@ -1,7 +1,7 @@ { "id": "messagesmusic", "name":"Messages Music", - "version":"0.01", + "version":"0.02", "description": "Uses Messages library to push a music message which in turn displays Messages app music controls", "icon":"app.png", "type": "app", From 8c6bfd96c6774e9d21c85e3ff8b8df933c72d97a Mon Sep 17 00:00:00 2001 From: thyttan <97237430+thyttan@users.noreply.github.com> Date: Tue, 5 Jul 2022 18:50:34 +0200 Subject: [PATCH 5/5] tested with messages v0.41 fw2v14 --- apps/messagesmusic/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/messagesmusic/README.md b/apps/messagesmusic/README.md index 8f9c65fa4..85608118d 100644 --- a/apps/messagesmusic/README.md +++ b/apps/messagesmusic/README.md @@ -6,7 +6,7 @@ Making the music controls accessible this way lets one start a music stream on t It is suggested to use Messages Music along side the app Quick Launch. -Messages Music v0.01 has been verified to work with Messages v0.31 on Bangle.js 2 fw2v13. +Messages Music v0.02 has been verified to work with Messages v0.41 on Bangle.js 2 fw2v14. Messages Music should work with forks of the original Messages app. At least as long as functions pushMessage() in the library and showMusicMessage() in app.js hasn't been changed too much.