bryan
/
BangleApps
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

settings: handle a `undefined` scroller (BJS1) 

Fixes #3824
master
Rob Pilling 2025-04-25 08:45:00 +01:00
parent 7010410c7e
commit 80cc3a609f
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/setting/ChangeLog
View File

@ -86,3 +86,4 @@ of 'Select Clock'
0.75: Restore previous menu's scroll positions 0.75: Restore previous menu's scroll positions
0.76: Add altitude calibration menu (and update README after menu changed) 0.76: Add altitude calibration menu (and update README after menu changed)
0.77: Save altitude calibration when user exits via reset 0.77: Save altitude calibration when user exits via reset
0.78: Fix menu scroll restore on BangleJS1

2
apps/setting/metadata.json
View File

@ -1,7 +1,7 @@
{ {
"id": "setting", "id": "setting",
"name": "Settings", "name": "Settings",
"version": "0.77", "version": "0.78",
"description": "A menu for setting up Bangle.js", "description": "A menu for setting up Bangle.js",
"icon": "settings.png", "icon": "settings.png",
"tags": "tool,system", "tags": "tool,system",

3
apps/setting/settings.js
View File

@ -27,7 +27,8 @@ function pushMenu(menu) {
function restoreMenu(menu) { function restoreMenu(menu) {
// equivalent to pushMenu(null); popMenu(menu); // equivalent to pushMenu(null); popMenu(menu);
if(!menu[""]) menu[""] = {}; if(!menu[""]) menu[""] = {};
menu[""].scroll = menuScroller.scroll; if(menuScroller) // may be undefined on BangleJS1
menu[""].scroll = menuScroller.scroll;
menuScroller = E.showMenu(menu).scroller; menuScroller = E.showMenu(menu).scroller;
} }