From aa99d5cea83b5fb9caba5890ef6b05cdf87be0fe Mon Sep 17 00:00:00 2001 From: Salim Blume Date: Sun, 27 Mar 2022 15:42:13 -0500 Subject: [PATCH] Reverting fix that was actually a bug --- apps/run/ChangeLog | 3 ++- apps/run/app.js | 4 ++-- apps/run/metadata.json | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/apps/run/ChangeLog b/apps/run/ChangeLog index 46fdb7e7e..9f1a547b1 100644 --- a/apps/run/ChangeLog +++ b/apps/run/ChangeLog @@ -9,4 +9,5 @@ 0.08: Added support for notifications from exstats. Support all stats from exstats 0.09: Fix broken start/stop if recording not enabled (fix #1561) 0.10: Don't allow the same setting to be chosen for 2 boxes (fix #1578) -0.11: Notifications fixes \ No newline at end of file +0.11: Notifications fixes +0.12: Fix for recorder not stopping at end of run. Bug introduced in 0.11 \ No newline at end of file diff --git a/apps/run/app.js b/apps/run/app.js index fb8158e58..19dcd7e88 100644 --- a/apps/run/app.js +++ b/apps/run/app.js @@ -59,7 +59,7 @@ function onStartStop() { layout.render(); }) ); - } else if (!settings.record && WIDGETS["recorder"]) { + } else { prepPromises.push( WIDGETS["recorder"].setRecording(false) ); @@ -68,7 +68,7 @@ function onStartStop() { if (!prepPromises.length) // fix for Promise.all bug in 2v12 prepPromises.push(Promise.resolve()); - + Promise.all(prepPromises) .then(() => { if (running) { diff --git a/apps/run/metadata.json b/apps/run/metadata.json index 09e5a3bed..b1b5617be 100644 --- a/apps/run/metadata.json +++ b/apps/run/metadata.json @@ -1,6 +1,6 @@ { "id": "run", "name": "Run", - "version":"0.11", + "version":"0.12", "description": "Displays distance, time, steps, cadence, pace and more for runners.", "icon": "app.png", "tags": "run,running,fitness,outdoors,gps",