From d1fe3c5c97aa4421b421bbd229d776dc645a9c77 Mon Sep 17 00:00:00 2001
From: Gordon Williams <gw@pur3.co.uk>
Date: Tue, 25 Feb 2020 14:05:59 +0000
Subject: [PATCH] Remove 'My Files' tab for now - it slowed down app uploads,
 may have confused non-techy users, and didn't cope with StorageFile.
 https://www.espruino.com/ide/ now has a shiny file loader that allows 
 viewing, deleting, and saving along with StorageFiles Issue open for 2 weeks
 and no interest either way so I'm assuming this is ok - shame though as it
 was a really neat addition (fix #99).

---
 index.html | 18 ------------------
 index.js   | 45 ---------------------------------------------
 2 files changed, 63 deletions(-)

diff --git a/index.html b/index.html
index 0141365b7..0aacaf1eb 100644
--- a/index.html
+++ b/index.html
@@ -56,9 +56,6 @@
       <li class="tab-item" id="tab-myappscontainer">
         <a href="javascript:showTab('myappscontainer')">My Apps</a>
       </li>
-      <li class="tab-item" id="tab-myfscontainer">
-        <a href="javascript:showTab('myfscontainer')">My files</a>
-      </li>
       <li class="tab-item" id="tab-aboutcontainer">
         <a href="javascript:showTab('aboutcontainer')">About</a>
       </li>
@@ -96,21 +93,6 @@
       </div>
     </div>
 
-    <div class="container bangle-tab" id="myfscontainer" style="display:none">
-      <div class="panel">
-        <div class="panel-header column col-12 container">
-          <div class="columns col-gapless">
-            <p class="column col-9">Files currently stored on the watch. Click row to download.</p>
-            <div class="column col-3" style="text-align:right">
-              <button class="btn refresh">Refresh...</button>
-            </div>
-          </div>
-        </div>
-        <table class="table table-striped table-hover panel-body">
-        </table>
-      </div>
-    </div>
-
     <div class="container bangle-tab" id="aboutcontainer" style="display:none">
       <div class="hero bg-gray">
         <div class="hero-body">
diff --git a/index.js b/index.js
index 1be285aa5..12391ee6a 100644
--- a/index.js
+++ b/index.js
@@ -413,7 +413,6 @@ return `<div class="tile column col-6 col-sm-12 col-xs-12">
 
 function getInstalledApps() {
   showLoadingIndicator("myappscontainer");
-  showLoadingIndicator("myfscontainer");
   // Get apps and files
   return Comms.getInstalledApps()
     .then(appJSON => {
@@ -421,11 +420,6 @@ function getInstalledApps() {
       refreshMyApps();
       refreshLibrary();
     })
-    .then(Comms.listFiles)
-    .then(list => {
-      files = list;
-      refreshMyFS();
-    })
     .then(() => handleConnectionChange(true));
 }
 
@@ -470,45 +464,6 @@ librarySearchInput.addEventListener('input', evt => {
   refreshLibrary();
 });
 
-
-// =========================================== My Files
-
-function refreshMyFS() {
-  var panelbody = document.querySelector("#myfscontainer .panel-body");
-  var tab = document.querySelector("#tab-myfscontainer a");
-  tab.setAttribute("data-badge", files.length);
-  panelbody.innerHTML = `
-    <thead>
-      <tr>
-        <th>Name</th>
-        <th>Type</th>
-      </tr>
-    </thead>
-    <tbody>${
-    files.map(file =>
-      `<tr data-name="${file}"><td>${escapeHtml(file)}</td><td>${fileType(file).name}</td></li>`
-    ).join("")}
-    </tbody>`;
-
-  htmlToArray(panelbody.getElementsByTagName("tr")).forEach(row => {
-    row.addEventListener("click",event => {
-      var name = event.target.closest('tr').dataset.name;
-      const type = fileType(name);
-      Comms.readFile(name).then(content => content.length && saveAs(new Blob([content], type), name));
-    });
-  });
-}
-
-function fileType(file) {
-  switch (file[0]) {
-    case "+": return { name: "App descriptor", type: "application/json;charset=utf-8" };
-    case "*": return { name: "App icon", type: "text/plain;charset=utf-8" };
-    case "-": return { name: "App code", type: "application/javascript;charset=utf-8" };
-    case "=": return { name: "Boot-time code", type: "application/javascript;charset=utf-8" };
-    default: return { name: "Plain", type: "text/plain;charset=utf-8" };
-  }
-}
-
 // =========================================== About
 
 document.getElementById("settime").addEventListener("click",event=>{