From 427fd49fa3bf07136be60232043780f9e8a97c6f Mon Sep 17 00:00:00 2001
From: Richard de Boer <richard@tubul.net>
Date: Sun, 28 Feb 2021 21:55:29 +0100
Subject: [PATCH] gbridge: fix HRM setting

The settings menu didn't handle `undefined` value for `hrm` properly, so
you were unable to toggle it.
Fixed by forcing the value to a boolean.
---
 apps.json                | 4 ++--
 apps/gbridge/ChangeLog   | 1 +
 apps/gbridge/settings.js | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/apps.json b/apps.json
index 17ad9eff2..c83dd74d2 100644
--- a/apps.json
+++ b/apps.json
@@ -139,7 +139,7 @@
   { "id": "gbridge",
     "name": "Gadgetbridge",
     "icon": "app.png",
-    "version":"0.20",
+    "version":"0.21",
     "description": "The default notification handler for Gadgetbridge notifications from Android",
     "tags": "tool,system,android,widget",
     "readme": "README.md",
@@ -2905,5 +2905,5 @@
     {"name":"arrow.app.js","url":"app.js"},
     {"name":"arrow.img","url":"icon.js","evaluate":true}
   ]
-}  
+}
 ]
diff --git a/apps/gbridge/ChangeLog b/apps/gbridge/ChangeLog
index 579d3580e..8023409b5 100644
--- a/apps/gbridge/ChangeLog
+++ b/apps/gbridge/ChangeLog
@@ -20,3 +20,4 @@
 0.18: Added reporting of step count and HRM (new Gadgetbridges can now log this)
 0.19: Support for call incoming/start/end
 0.20: Reduce memory usage
+0.21: Fix HRM setting
diff --git a/apps/gbridge/settings.js b/apps/gbridge/settings.js
index 42fa84a3e..afd0be4fb 100644
--- a/apps/gbridge/settings.js
+++ b/apps/gbridge/settings.js
@@ -31,7 +31,7 @@
     },
     "Find Phone" : function() { E.showMenu(findPhone); },
     "Record HRM" : {
-      value: settings().hrm,
+      value: !!settings().hrm,
       format: v => v?"Yes":"No",
       onchange: v => updateSetting('hrm', v)
     },