bryan
/
BangleApps_old
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1628 from GrandVizierOlaf/master 

Fix run bug where recorder did not stop.
master
Gordon Williams 2022-03-28 10:46:46 +01:00 committed by GitHub
parent c34ade140c beec98e835
commit e482707e89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/run/ChangeLog
View File

@ -9,4 +9,5 @@
0.08: Added support for notifications from exstats. Support all stats from exstats 0.08: Added support for notifications from exstats. Support all stats from exstats
0.09: Fix broken start/stop if recording not enabled (fix #1561) 0.09: Fix broken start/stop if recording not enabled (fix #1561)
0.10: Don't allow the same setting to be chosen for 2 boxes (fix #1578) 0.10: Don't allow the same setting to be chosen for 2 boxes (fix #1578)
0.11: Notifications fixes 0.11: Notifications fixes
0.12: Fix for recorder not stopping at end of run. Bug introduced in 0.11

4
apps/run/app.js
View File

@ -59,7 +59,7 @@ function onStartStop() {
layout.render(); layout.render();
}) })
); );
} else if (!settings.record && WIDGETS["recorder"]) { } else {
prepPromises.push( prepPromises.push(
WIDGETS["recorder"].setRecording(false) WIDGETS["recorder"].setRecording(false)
); );
@ -68,7 +68,7 @@ function onStartStop() {
if (!prepPromises.length) // fix for Promise.all bug in 2v12 if (!prepPromises.length) // fix for Promise.all bug in 2v12
prepPromises.push(Promise.resolve()); prepPromises.push(Promise.resolve());
Promise.all(prepPromises) Promise.all(prepPromises)
.then(() => { .then(() => {
if (running) { if (running) {

2
apps/run/metadata.json
View File

@ -1,6 +1,6 @@
{ "id": "run", { "id": "run",
"name": "Run", "name": "Run",
"version":"0.11", "version":"0.12",
"description": "Displays distance, time, steps, cadence, pace and more for runners.", "description": "Displays distance, time, steps, cadence, pace and more for runners.",
"icon": "app.png", "icon": "app.png",
"tags": "run,running,fitness,outdoors,gps", "tags": "run,running,fitness,outdoors,gps",