From eca40798282f5ebde99238c4581bc458835c793f Mon Sep 17 00:00:00 2001
From: Gordon Williams <gw@pur3.co.uk>
Date: Tue, 8 Mar 2022 13:00:31 +0000
Subject: [PATCH] Fix issue with code uploader where it'd silently refuse to
 upload code with warnings in

---
 apps/custom/custom.html | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/apps/custom/custom.html b/apps/custom/custom.html
index 684f813ae..307f2fd2f 100644
--- a/apps/custom/custom.html
+++ b/apps/custom/custom.html
@@ -16,12 +16,12 @@
     <script src="https://cdnjs.cloudflare.com/ajax/libs/jshint/2.11.0/jshint.min.js"></script>
     <p>Type your javascript code here</p>
     <p><textarea id="custom-js"></textarea></p>
-    <p>Then click <button id="upload" class="btn btn-primary">Upload</button></p>
+    <p>Then click <button id="upload" class="btn btn-primary">Upload</button>&nbsp;<span id="btninfo" style="color:orange"></span></p>
     <script>
     const item = "custom.boot.js";
     const id = "custom-js";
     const sample = "//Bangle.setOptions({wakeOnBTN2:false});";
-    var localeModule = null;
+    var customBootCode = null;
     var editor = {};
 
     if (localStorage.getItem(item) === null) {
@@ -48,15 +48,30 @@
         gutters: ["CodeMirror-linenumbers", "CodeMirror-lint-markers"],
         lineNumbers: true
     });
+    function hasWarnings() {
+      return editor.state.lint.marked.length!=0;
+    }
+
+    editor.on("change", function() {
+      setTimeout(function() {
+        if (hasWarnings()) {
+          document.getElementById("btninfo").innerHTML = "There are warnings in the code to be uploaded";
+          document.getElementById("upload").classList.add("disabled");
+        } else {
+          document.getElementById("btninfo").innerHTML = "";
+          document.getElementById("upload").classList.remove("disabled");
+        }
+      }, 500);
+    })
 
     document.getElementById("upload").addEventListener("click", function() {
-        if (!editor.state.lint.marked.length) {
-            localeModule = editor.getValue();
-            localStorage.setItem(item, localeModule);
-            sendCustomizedApp({
-                storage: [{ name: item, content: localeModule }]
-            });
-        }
+      if (!hasWarnings()) {
+        customBootCode = editor.getValue();
+        localStorage.setItem(item, customBootCode);
+        sendCustomizedApp({
+            storage: [{ name: item, content: customBootCode }]
+        });
+      }
     });
     </script>
 </body>